Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Zrustdoc-scrape-examples silently does nothing #10042

Closed
jyn514 opened this issue Nov 5, 2021 · 0 comments · Fixed by #10043
Closed

-Zrustdoc-scrape-examples silently does nothing #10042

jyn514 opened this issue Nov 5, 2021 · 0 comments · Fixed by #10043
Labels
C-bug Category: bug Z-scrape-examples Nightly: rustdoc scrape examples

Comments

@jyn514
Copy link
Member

jyn514 commented Nov 5, 2021

Problem

Cargo requires either -Zscrape-examples=all or -Zscrape-examples=examples; if you forget to pass a flag it will silently do nothing. This is a bad user experience, since it's not clear what's going wrong. Cargo should either give a hard error or default to all.

Steps

  1. cargo doc -Z rustdoc-scrape-examples

Possible Solution(s)

No response

Notes

No response

Version

cargo 1.58.0-nightly (94ca096af 2021-10-29)
release: 1.58.0
commit-hash: 94ca096afbf25f670e76e07dca754fcfe27134be
commit-date: 2021-10-29
host: x86_64-unknown-linux-gnu
libgit2: 1.3.0 (sys:0.13.23 vendored)
libcurl: 7.79.1-DEV (sys:0.4.49+curl-7.79.1 vendored ssl:OpenSSL/1.1.1l)
os: Pop!_OS 21.04 (hirsute) [64-bit]
@jyn514 jyn514 added the C-bug Category: bug label Nov 5, 2021
@jyn514 jyn514 changed the title -Zrustdoc-scrape-examples silently does nothing -Zrustdoc-scrape-examples silently does nothing Nov 5, 2021
@ehuss ehuss added the Z-scrape-examples Nightly: rustdoc scrape examples label Nov 6, 2021
@bors bors closed this as completed in 7a947ae Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug Z-scrape-examples Nightly: rustdoc scrape examples
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants