Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile-rustflags doesnt make cargo recompile the thing #11120

Closed
Hezuikn opened this issue Sep 21, 2022 · 0 comments · Fixed by #11981
Closed

profile-rustflags doesnt make cargo recompile the thing #11120

Hezuikn opened this issue Sep 21, 2022 · 0 comments · Fixed by #11981
Labels
A-rebuild-detection Area: rebuild detection and fingerprinting C-bug Category: bug Z-profile-rustflags Nightly: profile-rustflags

Comments

@Hezuikn
Copy link

Hezuikn commented Sep 21, 2022

Problem

adding, removing, changing profile rustflags doesnt make cargo recompile the thing

Steps

  • cargo clean
  • add rustflags = ["test"] to profile override
  • cargo build
  • comment out or replace with rustflags = []
  • cargo build
  • undo comment and replace with invalid flag
  • cargo build (passes but it shouldnt)

Possible Solution(s)

#11121

Notes

tracker #10271

Version

1.65.0 not that it matters
@Hezuikn Hezuikn added the C-bug Category: bug label Sep 21, 2022
@epage epage changed the title profile-rustflags impl is broken profile-rustflags doesnt make cargo recompile the thing Sep 21, 2022
@ehuss ehuss added A-rebuild-detection Area: rebuild detection and fingerprinting Z-profile-rustflags Nightly: profile-rustflags labels Dec 11, 2022
@bors bors closed this as completed in 60bf28f Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rebuild-detection Area: rebuild detection and fingerprinting C-bug Category: bug Z-profile-rustflags Nightly: profile-rustflags
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants