Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should make clear the credentials store path #11509

Closed
HomyeeKing opened this issue Dec 24, 2022 · 0 comments · Fixed by #11533
Closed

should make clear the credentials store path #11509

HomyeeKing opened this issue Dec 24, 2022 · 0 comments · Fixed by #11533
Labels
A-documenting-cargo-itself Area: Cargo's documentation C-enhancement Category: enhancement Command-login

Comments

@HomyeeKing
Copy link

HomyeeKing commented Dec 24, 2022

Merry Christmas :)

From here #7295 since 1.39, specifically this comment. However, the transition period was not what I expected or not finished. Feel like Cargo should by default write to credentials.toml.

I'd suggest transferring this to rust-lang/cargo. Cargo then can do such enhancements:

  • File a patch writing to credentials.toml if credentials doesn't exist.
  • Document the fallback behavior properly.
  • rust-lang/crates.io could cross-link to cargo doc to avoid doc duplicate.

Originally posted by @weihanglo in rust-lang/crates.io#5730 (comment)


I found the token was stored at ~/.cargo/credentials (create at yesterday by cargo login ) instead of ~/.cargo/credentials.toml, I thought it was a mistake of crate.io docs, but turn out that it's the mismatch logic of cargo.

I have same opinion with @weihanglo 👆

@HomyeeKing HomyeeKing changed the title From here https://github.com/rust-lang/cargo/pull/7295 since 1.39, specifically [this comment](https://github.com/rust-lang/cargo/blob/74c7aab19a9b3a045e7af13319409a9de2cf4ef7/src/cargo/util/config/mod.rs#L2096-L2098). However, the transition period was not what I expected or not finished. Feel like Cargo should by default write to credentials.toml. should make clear the credentials store path Dec 24, 2022
@HomyeeKing HomyeeKing reopened this Dec 24, 2022
@weihanglo weihanglo added A-documenting-cargo-itself Area: Cargo's documentation Command-login C-enhancement Category: enhancement I-nominated-to-discuss To be discussed during issue triage on the next Cargo team meeting labels Dec 26, 2022
@weihanglo weihanglo removed the I-nominated-to-discuss To be discussed during issue triage on the next Cargo team meeting label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documenting-cargo-itself Area: Cargo's documentation C-enhancement Category: enhancement Command-login
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants