Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make workspace inheritance support artifact dependencies #11625

Open
weihanglo opened this issue Jan 25, 2023 · 0 comments
Open

Make workspace inheritance support artifact dependencies #11625

weihanglo opened this issue Jan 25, 2023 · 0 comments
Labels
A-workspace-inheritance Area: workspace inheritance RFC 2906 C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` S-triage Status: This issue is waiting on initial triage. Z-bindeps Nightly: binary artifact dependencies

Comments

@weihanglo
Copy link
Member

Problem

Unstable feature artifact dependencies introduces several new fields on DetailedTomlDependency

/// One or more of `bin`, `cdylib`, `staticlib`, `bin:<name>`.
artifact: Option<StringOrVec>,
/// If set, the artifact should also be a dependency
lib: Option<bool>,
/// A platform name, like `x86_64-apple-darwin`
target: Option<String>,

It would be nice to support them in workspace inheritance.

Proposed Solution

After #11565 gets merged, add those fields here.

#[derive(Deserialize, Serialize, Clone, Debug)]
#[serde(rename_all = "kebab-case")]
pub struct TomlWorkspaceDependency {
workspace: bool,
features: Option<Vec<String>>,
default_features: Option<bool>,
#[serde(rename = "default_features")]
default_features2: Option<bool>,
optional: Option<bool>,
}

Notes

No response

@weihanglo weihanglo added the C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` label Jan 25, 2023
@weihanglo weihanglo added Z-bindeps Nightly: binary artifact dependencies A-workspace-inheritance Area: workspace inheritance RFC 2906 labels Jan 25, 2023
@epage epage added the S-triage Status: This issue is waiting on initial triage. label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-workspace-inheritance Area: workspace inheritance RFC 2906 C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` S-triage Status: This issue is waiting on initial triage. Z-bindeps Nightly: binary artifact dependencies
Projects
None yet
Development

No branches or pull requests

2 participants