Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo fix checks packages twice, even if nothing was fixed #13215

Closed
epage opened this issue Dec 29, 2023 · 0 comments · Fixed by #13243
Closed

cargo fix checks packages twice, even if nothing was fixed #13215

epage opened this issue Dec 29, 2023 · 0 comments · Fixed by #13243
Assignees
@ehuss
Labels
C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` Command-fix Performance Gotta go fast! S-triage Status: This issue is waiting on initial triage.

Comments

@epage
Copy link
Contributor

epage commented Dec 29, 2023

Problem

Running cargo fix (and worse, cargo clippy --fix on https://github.com/crate-ci/typos is very slow. For clippy, its over 2m.

Proposed Solution

Only re-check the package (to show errors/warnings) if there was output from the first run.

Notes

See also https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/Performance.20of.20.60cargo.20fix.60
@epage epage added C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` Command-fix S-triage Status: This issue is waiting on initial triage. labels Dec 29, 2023
@weihanglo weihanglo added the Performance Gotta go fast! label Dec 29, 2023
@ehuss ehuss self-assigned this Dec 31, 2023
@ehuss ehuss mentioned this issue Jan 2, 2024
Merged
@bors bors closed this as completed in dfdd5ff Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ehuss ehuss

Labels
C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` Command-fix Performance Gotta go fast! S-triage Status: This issue is waiting on initial triage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cargo fix: Call rustc fewer times. ehuss/cargo
3 participants
@ehuss @epage @weihanglo