Skip to content

Cargo bench should put deliminators on nanosecond numbers #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mdinger opened this issue Jun 8, 2015 · 2 comments
Closed

Cargo bench should put deliminators on nanosecond numbers #1696

mdinger opened this issue Jun 8, 2015 · 2 comments

Comments

@mdinger
Copy link
Contributor

mdinger commented Jun 8, 2015

This might be a rust issue but I'm not sure. From this initial rust experience blog, cargo bench should report nanosecond times as 3_000_000 or 3,000,000, not 3000000
@alexcrichton
Copy link
Member

Thanks for the report! This code actually lives in the libtest library of the standard distribution, so could you open this bug up against rust-lang/rust instead of Cargo?

@mdinger
Copy link
Contributor Author

mdinger commented Jun 8, 2015

@alexcrichton Done at rust-lang/rust#26109. Thanks for directing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @mdinger