Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build script output shouldn't be completely in red #2401

Closed
LukasKalbertodt opened this issue Feb 20, 2016 · 4 comments
Closed

Build script output shouldn't be completely in red #2401

LukasKalbertodt opened this issue Feb 20, 2016 · 4 comments

Comments

@LukasKalbertodt
Copy link
Member

Hi there,

if the build script fails, cargo prints it's output -- sadly completely in red. It looks like:

red

But it's of course useful to format the output specifically to make it more readable, like so:

color

I assume that cargo saves the output to a string, which is printed only if the build script exited with a non 0 status. In this case, restoring colors could be difficult. But I'd like to have nice build script output...

@alexcrichton
Copy link
Member

Yeah the UI here unfortunately isn't great, I've long since wished we could do better! This is somewhat related to #1106 as well.

Unfortunately capturing colorization would only work on Unix, but it may just be a case where we should do the best we can on each platform.

@LukasKalbertodt
Copy link
Member Author

Or we could provide some kind of API, that the build script can call to get access to stdout. It would be some "annoying" synchronization between processes, but it could work...

Making it possible on Unix alone would be fine by me, too ;)

@sbeckeriv
Copy link
Contributor

The error messages are no longer in red on master. It does not fix the display of the original color of the message.

Related pull request #2421

@carols10cents
Copy link
Member

The error messages are no longer in red on master.

Sounds like this is fixed, please reopen if I'm incorrect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants