Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo check: re-use rlibs if possible #3341

Closed
nrc opened this issue Nov 28, 2016 · 3 comments
Closed

cargo check: re-use rlibs if possible #3341

nrc opened this issue Nov 28, 2016 · 3 comments

Comments

@nrc
Copy link
Member

nrc commented Nov 28, 2016

The current cargo check architecture (#3296) always uses rmeta files, even if an rlib is available, that means that if the rlib doesn't need to be rebuilt, then work is wasted. It would be good to use the rlib if possible.

This is a bit complex because:

  • we specify the file in an --extern arg to rustc, therefore we need to know which to use,
  • even if the rlib is fresh, one of its dependencies might not be, causing it to be rebuilt, if that happens we should just build an rmeta, not an rlib,
  • we therefore don't know until after the crate is built whether we should pass the rmeta or rlib using --extern
  • that info is not easily available in Cargo right now.
@Dushistov
Copy link

Dup of #3501 ?

@RalfJung
Copy link
Member

RalfJung commented Jun 8, 2017

Yeah, very much looks like a dup.

@alexcrichton
Copy link
Member

Ah, yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants