Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown sections are silently ignored for virtual manifest #4491

Closed
RalfJung opened this issue Sep 14, 2017 · 2 comments
Closed

Unknown sections are silently ignored for virtual manifest #4491

RalfJung opened this issue Sep 14, 2017 · 2 comments
Labels
A-diagnostics Area: Error and warning messages generated by Cargo itself.

Comments

@RalfJung
Copy link
Member

RalfJung commented Sep 14, 2017

For a virtual manifest (no [package] section), unknown sections in the Cargo.toml sections are silently ignored. For non-virtual packages, however, they trigger a warning.

Behavior should be consistent, and probably also trigger a warning for virtual manifests.

Also see rust-lang/rfcs#1133 (comment).

@alexcrichton alexcrichton added the A-diagnostics Area: Error and warning messages generated by Cargo itself. label Sep 14, 2017
@Ericson2314
Copy link
Contributor

Ericson2314 commented Sep 14, 2017

I'd like all unrecognized data to cause an error---failing fast during configuring is a better user experience than mysterious failure during building. After all, we don't like rustc skip language features it doesn't understand!

Plugins for declarative build.rs replacements can declare what non-standard sections they parse, analogous to the plan for attribute-like procedural macros in Rust.

@ehuss
Copy link
Contributor

ehuss commented Nov 7, 2018

This was fixed in #5726.

@ehuss ehuss closed this as completed Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Error and warning messages generated by Cargo itself.
Projects
None yet
Development

No branches or pull requests

4 participants