Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to hide output from successful test binaries. #5089

Closed
kevincox opened this issue Feb 27, 2018 · 6 comments
Closed

Add option to hide output from successful test binaries. #5089

kevincox opened this issue Feb 27, 2018 · 6 comments
Labels
A-console-output Area: Terminal output, colors, progress bar, etc. Command-test E-hard Experience: Hard S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted.

Comments

@kevincox
Copy link

Right now passing tests in a harness have no output shown which is nice for seeing the output of those that have failed. However if you have tests in multiple targets (for example in lib/, tests/ bin/...) the output quickly gets to be quite noisy.

   Compiling ecl v0.1.0 (file:///home/kevincox/p/ecl)
warning: unused import: `thunk::Thunk`
 --> src/dict.rs:9:5
  |
9 | use thunk::Thunk;
  |     ^^^^^^^^^^^^
  |
  = note: #[warn(unused_imports)] on by default

    Finished dev [unoptimized + debuginfo] target(s) in 9.16 secs
     Running target/debug/deps/ecl-a3de2a1c73e991ba

running 13 tests
test builtins::tests::assert_once_once ... ok
test bytecode::tests::compile_global ... ok
test builtins::tests::assert_once_twice ... ok
test grammar::tests::num_hex ... ok
test tests::ident ... ok
test builtins::tests::panic ... ok
test grammar::tests::num_binary ... ok
test tests::val_is_gc_sized ... ok
test tests::list ... ok
test grammar::tests::num_decimal ... ok
test dict::tests::dict ... ok
test tests::recursion ... ok
test tests::recursion_multi_step ... ok

test result: ok. 13 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/ast-e414ddb60918e758

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/ecl-bff861297faac3d7

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/tree-a9e09fe64622dc5d

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/compile-3fed4c7317d42ec1

running 1 test
test test_compile_lines ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/lines-3858789213e13cf3

running 1 test
test test_lines ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

   Doc-tests ecl

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

Some of these binaries have no tests and a couple of them only have a single test case. However they print at least 6 lines each. Pushing the warning off the top of my screen.

It would be great if there was an option to hide successful test harness output by default. This would probably require a "all good" message at the end to confirm the everything is complete but would nicely keep errors near the bottom and noise low.

@alexcrichton
Copy link
Member

Libtest in rust-lang/rust is what's printing most of this, so maybe this would be best reported there?

@kevincox
Copy link
Author

kevincox commented Feb 27, 2018

I disagree (although there might also be improvements that could be made there). I think that we want to hide the output regardless of the source. The libtest output is just an example of a general problem.

@stale
Copy link

stale bot commented Sep 16, 2018

As there hasn't been any activity here in over 6 months I've marked this as stale and if no further activity happens for 7 days I will close it.

I'm a bot so this may be in error! If this issue should remain open, could someone (the author, a team member, or any interested party) please comment to that effect?

The team would be especially grateful if such a comment included details such as:

  • Is this still relevant?
  • If so, what is blocking it?
  • Is it known what could be done to help move this forward?

Thank you for contributing!

If you're reading this comment from the distant future, fear not if this was closed automatically. If you believe it's still an issue please leave a comment and a team member can reopen this issue. Opening a new issue is also acceptable!

@stale stale bot added the stale label Sep 16, 2018
@kevincox
Copy link
Author

This is still relevant because it is still making it awkward to manage projects with a lot of test binaries.

@stale stale bot removed the stale label Sep 17, 2018
@ehuss ehuss added A-console-output Area: Terminal output, colors, progress bar, etc. Command-test labels Sep 23, 2019
@weihanglo weihanglo added E-hard Experience: Hard S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted. labels May 14, 2023
@epage epage changed the title Add option to hide all errors from successful test binaries. Add option to hide output from successful test binaries. Jun 2, 2023
@epage
Copy link
Contributor

epage commented Jun 2, 2023

@epage
Copy link
Contributor

epage commented Oct 18, 2023

Closing in favor of #2832 + #4324

@epage epage closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-console-output Area: Terminal output, colors, progress bar, etc. Command-test E-hard Experience: Hard S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted.
Projects
None yet
Development

No branches or pull requests

5 participants