-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cargo should be able to conditionally build targets #6617
Comments
We also have a similar problem and I think it is due to the fact that cargo downloads and compiles all the dependencies even though they're not used on the platform that we're building on. It looks to me that cargo is ignoring the targets & profiles specified in |
I also having similar same problem. cargo profile may be replaced in this configuration concept? |
Looks like #9208 is a duplicate of this but it has more discussions, so I'm closing this in favor of that. If there is something I overlooked, let us know! |
Describe the problem you are trying to solve
Some targets, especially
[[test]]
targets, don't make sense to run on every platform. Cargo should allow you to conditionally enable them in the manifest. On Nix this merely causes an annoyance; some tests must have their entire bodies#[cfg()]
ed out. But on libc the problem is more severe; the s390x and sparc64 targets crash in the test harness before executing any tests. There's no way to fix that problem from within test code itself; a Cargo solution is required.Describe the solution you'd like
It would be great if the
[[test]]
section could be conditionally enabled, like this:or this:
Notes
Here's a PR that shows s390x and sparc64 failing early in the test harness.
rust-lang/libc#1235
The text was updated successfully, but these errors were encountered: