Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for --explicit-version in cargo vendor #7291

Closed
acmcarther opened this issue Aug 23, 2019 · 4 comments
Closed

Support for --explicit-version in cargo vendor #7291

acmcarther opened this issue Aug 23, 2019 · 4 comments
Labels
C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` Command-vendor

Comments

@acmcarther
Copy link
Contributor

As requested by the embedded error message on flag usage, I'm filing this bug to request re-inclusion of versioning functionality.

I maintain cargo-raze, a tool that generates BUILD files for Cargo dependencies for projects using the Bazel build tool. Historically the cargo-vendor crate has been a primary component of our "pre vendored dependency" use case, and we rely on explicitly versioned crate directory output in order to make the generated output directories more predictable.

Without this functionality, we'll need to suggest users continue to use the cargo-vendor crate, deprecate the vendored dependency use case, or package this functionality into our own crate.

@acmcarther acmcarther added the C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` label Aug 23, 2019
@apoelstra
Copy link

Is there any way to update the toolchain past 1.36 with this bug present?

@apoelstra
Copy link

Ah! Directly calling cargo-vendor vendor (two vendors) is the workaround.

@jgallagher
Copy link

Is this resolved as of #7631? (Sorry if this is an out-of-left-field comment, but I was just poking around and noticed that cargo-raze as linked in the original request had updated its Readme to reference the new --versioned-dirs flag added in that PR.)

@ehuss
Copy link
Contributor

ehuss commented Feb 4, 2020

Yes, this appears to be done, thanks!

@ehuss ehuss closed this as completed Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` Command-vendor
Projects
None yet
Development

No branches or pull requests

4 participants