Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo is not excluding target/ directories from MacOS time machine #7317

Closed
orf opened this issue Sep 1, 2019 · 3 comments
Closed

Cargo is not excluding target/ directories from MacOS time machine #7317

orf opened this issue Sep 1, 2019 · 3 comments
Labels
C-bug Category: bug

Comments

@orf
Copy link

orf commented Sep 1, 2019

Problem
Seems to be the same as #7189. Cargo no longer marks target/, or any subdirectories, as excluded from time machine backups. This causes lots of backup bloat!

Steps

  1. Run cargo new my-cool-project
  2. Run cargo build my-cool-project
  3. Run tmutil isexcluded target/ and see that it says the target/ directory is included in backups.

Possible Solution(s)
The current implementation seems too fragile, as it's broken before and it's broken now. Simply setting the com.apple.metadata:com_apple_backup_excludeItem xattr on the directory is enough, rather than invoking an Objective-C framework method.

Notes

Output of cargo version: cargo 1.37.0 (9edd089 2019-08-02)

Latest MacOS.

@orf orf added the C-bug Category: bug label Sep 1, 2019
@orf
Copy link
Author

orf commented Sep 1, 2019

CC @alexcrichton - sorry for the notification, but I saw you worked on this in #7189.

@ehuss
Copy link
Contributor

ehuss commented Sep 1, 2019

It was fixed in 1.38, did you try that version?

@orf
Copy link
Author

orf commented Sep 1, 2019

I feel so stupid, I'm sorry. I thought that it was fixed in 1.37. Confirmed it works as expected in 1.38.0.

@orf orf closed this as completed Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug
Projects
None yet
Development

No branches or pull requests

2 participants