Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo Build Timings graph hits browser’s max canvas size #7436

Closed
SimonSapin opened this issue Sep 26, 2019 · 4 comments
Closed

Cargo Build Timings graph hits browser’s max canvas size #7436

SimonSapin opened this issue Sep 26, 2019 · 4 comments

Comments

@SimonSapin
Copy link
Contributor

https://gistpreview.github.io/?eeb6459081cf75648d507eeaf1d414f3 is cargo build -Z timings for Servo. The canvas appears broken in Firefox and Chromium until the "Min unit time" slider is moved to a non-zero value. This appears to be because the canvas height exceeds i16::MAX:

Changing "Min unit time" to even 0.1 seconds filters out many units/crates, making a much smaller canvas.

I’m not sure what a proper solution would be, but maybe we could at least detect this situation and suggest that work-around?

@SimonSapin
Copy link
Contributor Author

I’m not sure what a proper solution would be,

Maybe splitting the graph into multiple <canvas> elements? @ehuss, @alexcrichton, how involved would that be?

@nox
Copy link
Contributor

nox commented Sep 26, 2019

Alternatively, maybe rustc should be producing something that can be fed to https://profiler.firefox.com/.

@SimonSapin
Copy link
Contributor Author

@nox that could be good also, but an entirely different feature from Cargo’s -Z timings which IMO is about exploring dependencies in the crate graph.

@alexcrichton
Copy link
Member

I believe this was fixed in #7397 which just hasn't made its way to nightly yet, but let us know if it's still not working after that update hits though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants