Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate dependency checking for CI #7941

Closed
joshtriplett opened this issue Feb 26, 2020 · 2 comments
Closed

Duplicate dependency checking for CI #7941

joshtriplett opened this issue Feb 26, 2020 · 2 comments
Labels
C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`

Comments

@joshtriplett
Copy link
Member

(Filing this issue based on a discussion from the cargo team meeting today.)

For use in CI, we'd like to have an option for a gentle nudge to fix duplicate dependencies in your dependency graph, which doesn't fail unless you can actually fix the problem without having to fix your dependencies. The algorithm would be "pretend that all of your direct declared dependencies (and also dependencies from crates in your workspace or that use path dependencies) that use ~ (semver compatible) used >= instead, resolve dependencies accordingly, and if that would eliminate a duplicate, report it as a failure".

That way, you don't get a CI failure for something that you can't actually fix yourself by just fixing your Cargo.toml.

See also sfackler/cargo-tree#87 .

@joshtriplett joshtriplett added the C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` label Feb 26, 2020
@ehuss
Copy link
Contributor

ehuss commented Feb 26, 2020

cc #7285

@epage
Copy link
Contributor

epage commented Nov 3, 2023

Closing in favor of #7285

@epage epage closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`
Projects
None yet
Development

No branches or pull requests

3 participants