Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI parsing regression between 1.48.0 and 1.49.0 #9267

Closed
alexcrichton opened this issue Mar 15, 2021 · 3 comments
Closed

CLI parsing regression between 1.48.0 and 1.49.0 #9267

alexcrichton opened this issue Mar 15, 2021 · 3 comments
Labels
A-cli Area: Command-line interface, option parsing, etc.

Comments

@alexcrichton
Copy link
Member

I recently received rustwasm/wasm-bindgen#2490 as a bug report but it looked suspicious to me. Turns out the parsing for CLI arguments has changed between 1.48.0 and 1.49.0, which may have broken old build scripts! I'm not sure if this was intentional but I suspect it wasn't, so I figured I'd open an issue.

@ehuss
Copy link
Contributor

ehuss commented Mar 15, 2021

I suspect this is due to #8808?

@alexcrichton
Copy link
Member Author

Hm yeah that does look like a likely culprit :(

@ehuss ehuss added the A-cli Area: Command-line interface, option parsing, etc. label Mar 30, 2021
@Eh2406
Copy link
Contributor

Eh2406 commented May 27, 2021

I will Close as won't fix. This was a braking change, but the new behavior is on stable for a while. So it will also be a braking change to go back, and we mostly like the new way thing work. If you disagree feel free to comment or reopen.

@Eh2406 Eh2406 closed this as completed May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area: Command-line interface, option parsing, etc.
Projects
None yet
Development

No branches or pull requests

3 participants