cargo vendor breaks crates such as rusty_v8, removes .gn file

[apaprocki]

cargo/src/cargo/sources/path.rs

Lines 110 to 121 in 070e459

	let no_include_option = pkg.manifest().include().is_empty();
	let git_repo = if no_include_option {
	self.discover_git_repo(root)?
	} else {
	None
	};
	let mut exclude_builder = GitignoreBuilder::new(root);
	if no_include_option && git_repo.is_none() {
	// no include option and not git repo discovered (see rust-lang/cargo#7183).
	exclude_builder.add_line(None, ".*")?;
	}

The denoland/rusty_v8 crate has a .gn file that is included by saying:

exclude = [
 ...
 ".*",
 ...
 "!.gn"
]

This excludes all dotfiles except .gn, but when this crate is vendored into a project, the .gn file is missing. Given that this is legal syntax, it seems the path.rs logic above needs to handle this situation?

[ehuss]

This should be fixed via #9186. Can you try the latest nightly to see if it works? cargo +nightly package --list can be used to verify which files are included.

[weihanglo]

This snippet can also verify the exclusion rule.

git clone https://github.com/denoland/deno.git
cd deno
cargo +nightly vendor
ls vendor/rusty_v8/.gn

In addition, these files cannot be re-included due to the limitation of gitignore rule.

It is not possible to re-include a file if a parent directory of that file is excluded. Git doesn’t list excluded directories for performance reasons, so any patterns on contained files have no effect, no matter where they are defined.

[samanpa]

Confirmed that it works on nightly.

[PaulDance]

@apaprocki Does it work on nightly for you as well?

[apaprocki]

@PaulDance yes, nightly worked

[ehuss]

Thanks for the check, closing as fixed by #9186.