Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare stabilizing Rust 2021 #9781

Closed
m-ou-se opened this issue Aug 12, 2021 · 3 comments · Fixed by #9800
Closed

Prepare stabilizing Rust 2021 #9781

m-ou-se opened this issue Aug 12, 2021 · 3 comments · Fixed by #9800
Assignees
Labels
A-editions Area: edition-specific issues

Comments

@m-ou-se
Copy link
Member

m-ou-se commented Aug 12, 2021

Rust 2021 will probably be stabilied soon. Cargo also has knowledge of which editions are stable, so should be updated too. It'd be good to prepare that PR, so we can merge it as soon the edition is stabilized in rustc.

Alternatively, can we make it such that Cargo will allow --edition=2021 but will not pass -Z unstable-options when the edition2021 cargo feature is not enabled? Then it'll be usable as soon as rustc allows it, without having to do the cargo change in sync.

@m-ou-se
Copy link
Member Author

m-ou-se commented Aug 12, 2021

cc @ehuss

@ehuss
Copy link
Contributor

ehuss commented Aug 15, 2021

Alternatively, can we make it such that Cargo will allow --edition=2021 but will not pass -Z unstable-options

I would kinda prefer to avoid doing that, since it requires probing rustc to see what it supports. We can land cargo support within a few days after it lands in rustc. I'm not too concerned about the small window in-between.

I can post a draft PR to prep things, though.

@ehuss ehuss self-assigned this Aug 15, 2021
@ehuss ehuss added the A-editions Area: edition-specific issues label Aug 15, 2021
@ehuss
Copy link
Contributor

ehuss commented Aug 17, 2021

Opened #9800 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-editions Area: edition-specific issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants