Skip to content

bug: Build::is_flag_supported /guard:cf returns false on 1.2.4 ->1.2.5 transition (on x86_64-pc-windows-msvc) #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
omerkattan-microsoft opened this issue Feb 26, 2025 · 2 comments · Fixed by #1417
Labels
bug O-windows Windows targets and toolchains

Comments

@omerkattan-microsoft
Copy link

Seems related to #1324
The build output looks like that in 1.2.5, while these messages don't show up in 1.2.4:
Image

When manually running the flag check command I get the following output:
Image

This in practice disables control flow guard mitigation for projects compiled with cc.
It is possible that /guard:cf adds a link dependency on MSVCRT.lib and the fix for #1324 didn't take that into account.

@ChrisDenton
Copy link
Member

Oh, that's not great. Fix in #1417.

@omerkattan-microsoft
Copy link
Author

Wow that was quick!
I confirmed that the issue does not reproduce on your branch.
Thank you!

@madsmtm madsmtm added bug O-windows Windows targets and toolchains labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug O-windows Windows targets and toolchains
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants