add clippy to CI

Author: AaronKutch

.github/workflows/main.yml

@@ -109,6 +109,21 @@ jobs:
     - uses: actions/checkout@v1
       with:
         submodules: true
-    - name: Install Rust
-      run: rustup update stable && rustup default stable && rustup component add rustfmt
+    - name: Install stable `rustfmt`
+      run: rustup set profile minimal && rustup default stable && rustup component add rustfmt
     - run: cargo fmt -- --check
+
+  clippy:
+    name: Clippy
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v1
+      with:
+        submodules: true
+    # Unlike rustfmt, stable clippy does not work on code with nightly features.
+    # This acquires the most recent nightly with a clippy component.
+    - name: Install nightly `clippy`
+      run: |
+        $CLIPPY_NIGHTLY="nightly-$(curl -s https://rust-lang.github.io/rustup-components-history/x86_64-unknown-linux-gnu/clippy)"
+        rustup set profile minimal && rustup default "$CLIPPY_NIGHTLY" && rustup component add clippy
+    - run: cargo clippy -- -D clippy::all

src/int/mod.rs

@@ -59,6 +59,9 @@ pub trait Int:
     const FUZZ_NUM: usize;
 
     fn unsigned(self) -> Self::UnsignedInt;
+
+    // It makes writing macros easier if this is implemented for both signed and unsigned
+    #[allow(clippy::wrong_self_convention)]
     fn from_unsigned(unsigned: Self::UnsignedInt) -> Self;
 
     fn from_bool(b: bool) -> Self;