You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In build.rs, there is code to use the random generator to create floats.
It has a little bug though in the way it determines the exponent. The exponent is first &ed with the mask, and then shifted. The issue is though, the mask is already assuming a shifted value. So we end up with the expression always being 0.
Instead it should be first shifted, and then &ed with the mask, like ((exponent << (SIGNIFICAND_BITS -1)) & EXPONENT_MASK) |.
When doing this though, I discovered that the fixdfti test fails. I first thought it was a conversion my PR added, but its in fact already present.
In build.rs, there is code to use the random generator to create floats.
It has a little bug though in the way it determines the exponent. The exponent is first &ed with the mask, and then shifted. The issue is though, the mask is already assuming a shifted value. So we end up with the expression always being 0.
Instead it should be first shifted, and then &ed with the mask, like
((exponent << (SIGNIFICAND_BITS -1)) & EXPONENT_MASK) |
.When doing this though, I discovered that the
fixdfti
test fails. I first thought it was a conversion my PR added, but its in fact already present.The error looks like:
The text was updated successfully, but these errors were encountered: