Emit _fltused on uefi targets as a short-term workaround
#317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
reviewed
Oct 2, 2019
| FROM ubuntu:18.04 | ||
| RUN apt-get update && \ | ||
| apt-get install -y --no-install-recommends \ | ||
| gcc libc6-dev ca-certificates |
There was a problem hiding this comment.
Is this intended to be hooked up to CI? (it doesn't happen automatically, extra configuration would be needed)
There was a problem hiding this comment.
@oli-obk can we do CI configs in a follow up PR, so that this fix can get merged?
|
This is blocking rust-lang/rust#62785 @alexcrichton can you respond to @josephlr 's question regarding handling of CI? |
|
I've removed the CI changes for now. |
|
I've published 0.1.20 with this change to get pulled into the compiler |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Dec 9, 2019
Bump compiler-builtins - rust-lang/compiler-builtins#306 - rust-lang/compiler-builtins#309 - rust-lang/compiler-builtins#310 - rust-lang/compiler-builtins#311 - rust-lang/compiler-builtins#312 - rust-lang/compiler-builtins#313 - rust-lang/compiler-builtins#315 - rust-lang/compiler-builtins#317 - rust-lang/compiler-builtins#323 - rust-lang/compiler-builtins#324 - rust-lang/compiler-builtins#328 Adds support for backtraces from `__rust_probestack` plus other goodies. r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes rust-lang/rust#62785