Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically accept/reject beta/stable nominations #12

Open
spastorino opened this issue Aug 19, 2020 · 8 comments
Open

Automatically accept/reject beta/stable nominations #12

spastorino opened this issue Aug 19, 2020 · 8 comments
Assignees

Comments

@spastorino
Copy link
Member

It would be cool if from the meeting we could say @triagebot beta-accept #1111 or @triagebot beta-reject #1111 and have triagebot adding a comment on github doing what needs to be done to accept/reject a backport.

@apiraino
Copy link
Contributor

apiraino commented Oct 12, 2020

@spastorino I'm on this issue.

Can you detail a bit what you mean by "what needs to be done to accept/reject a backport"? I was thinking to apply either the label beta-accepted or beta-rejected.

Perhaps would you like something more like in this comment?

@apiraino apiraino self-assigned this Oct 12, 2020
@spastorino
Copy link
Member Author

Perhaps would you like something more like in this comment?

👍, we should just fire that comment that also does the labelling adjustments.

@LeSeulArtichaut
Copy link

Can you detail a bit what you mean by "what needs to be done to accept/reject a backport"? I was thinking to apply either the label beta-accepted or beta-rejected.

Btw there is no beta-rejected label. The procedure is "add beta-accepted (without removing beta-nominated) if accepted, or remove beta-nominated if rejected.
I think the detailed procedure can be found in the Forge

@LeSeulArtichaut
Copy link

Also does triagebot have a proper code structure to create Zulip commands more easily now?

@apiraino
Copy link
Contributor

Btw there is no beta-rejected label. The procedure is "add beta-accepted (without removing beta-nominated) if accepted, or remove beta-nominated if rejected.

ah good point, didn't know that. Are you referring to this documentation? In my opinion, not as clear as you wrote it here. Worth a small PR to clarify the wording?

Also does triagebot have a proper code structure to create Zulip commands more easily now?

mmm are you referring perhaps to issue #1 ? I can't tell, don't know what the plan was. I'm still wrapping my head and figuring out the actual workflow and API to/from Zulip, so I may be off, but by reading the code I think that commands have their own handler and adding a new handler is some copy&paste.

@spastorino
Copy link
Member Author

Btw there is no beta-rejected label. The procedure is "add beta-accepted (without removing beta-nominated) if accepted, or remove beta-nominated if rejected.

ah good point, didn't know that. Are you referring to this documentation? In my opinion, not as clear as you wrote it here. Worth a small PR to clarify the wording?

I think @LeSeulArtichaut refers to our wg procedure document, I think there it's clear or at least should :).

@camelid
Copy link
Member

camelid commented Oct 21, 2020

I believe this should be moved to rust-lang/triagebot – cc @Mark-Simulacrum

@LeSeulArtichaut
Copy link

I'd argue that it's still useful to at list keep an issue here. It's a todo list of the things we want to have. We could link this to an issue in rust-lang/triagebot maybe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants