Skip to content

Major change proposal: Support collecting all identifiers encountered during compilation #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crlf0710 opened this issue Apr 18, 2020 · 2 comments
Closed

Major change proposal: Support collecting all identifiers encountered during compilation #276

crlf0710 opened this issue Apr 18, 2020 · 2 comments
Labels
major-change A proposal to make a major change to rustc

Comments

@crlf0710
Copy link
Member

TL;DR

To implement confusable_idents lint in RFC 2457, we need a mechanism to collect all unique identifiers occurred during compilation.

Links and Details

The requirement raised up from RFC 2457. Fundamentally, it means that each occurred identifier should be hashed with a very specific hash function called skeleton and storing the results. The lint is about checking whether hash collisions occurred during compilation. Whenever that happens, it raises warnings or errors.

Mentors or Reviewers

(TBD)
@crlf0710 crlf0710 added the major-change A proposal to make a major change to rustc label Apr 18, 2020
@rustbot rustbot added the to-announce Announce this issue on triage meeting label Apr 18, 2020
@spastorino
Copy link
Member

Added to our compiler team meeting agenda, removing to-announce label.

@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Apr 23, 2020
@crlf0710
Copy link
Member Author

crlf0710 commented May 3, 2020

Done and merged in rust-lang/rust#71542 , i'm gonna close this.

@crlf0710 crlf0710 closed this as completed May 3, 2020
@spastorino spastorino added major-change-accepted A major change proposal that was accepted and removed major-change-accepted A major change proposal that was accepted labels Jun 8, 2020
@mrluc mrluc mentioned this issue Nov 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@spastorino @crlf0710 @rustbot