Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#[deny(unsafe_op_in_unsafe_fn)] in liballoc #306

Closed
3 tasks done
LeSeulArtichaut opened this issue Jun 8, 2020 · 5 comments
Closed
3 tasks done

#[deny(unsafe_op_in_unsafe_fn)] in liballoc #306

LeSeulArtichaut opened this issue Jun 8, 2020 · 5 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@LeSeulArtichaut
Copy link
Contributor

LeSeulArtichaut commented Jun 8, 2020 •
edited
Loading

Proposal

Deny the newly-added unsafe_op_in_unsafe_fn lint in liballoc, which means that unsafe operations inside unsafe functions require an explicit unsafe block.

Motivation

This is an opportunity for the language team to see the impact of the lint and decide of its future. It is also useful in the context of liballoc, where there are a lot of unsafe functions containing both safe and unsafe operations.

Drawbacks

If the lint is removed, these additional unsafe blocks should be removed. However, this can probably be done automatically using e.g. cargo fix.

Links

Mentors or Reviewers

@Mark-Simulacrum is willing to second this. @RalfJung may also review as well?

Process

The main points of the Major Change Process is as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@LeSeulArtichaut LeSeulArtichaut added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Jun 8, 2020
@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jun 8, 2020
@nikomatsakis
Copy link
Contributor

@bors second

I'd like us to see more this feature "weathers" in libstd, and the downsides of this seem quite minimal.

@nikomatsakis
Copy link
Contributor

@rustbot second

ETOOMANYBOTS

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Jun 9, 2020
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Jun 10, 2020
@LeSeulArtichaut LeSeulArtichaut mentioned this issue Jun 12, 2020
Merged
@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jun 16, 2020
@rustbot
Copy link
Collaborator

rustbot commented Jun 16, 2020 •
edited by Mark-Simulacrum
Loading

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Jun 17, 2020
@LeSeulArtichaut
Copy link
Contributor Author

So IIUC, MCPs need to be manually marked as accepted and closed? cc @nikomatsakis @spastorino

@nikomatsakis nikomatsakis added the major-change-accepted A major change proposal that was accepted label Jun 19, 2020
@nikomatsakis
Copy link
Contributor

FCP expired, marking as accepted. Thanks @LeSeulArtichaut !

@LeSeulArtichaut LeSeulArtichaut mentioned this issue Jun 22, 2020
Closed
3 tasks
@spastorino spastorino removed the final-comment-period The FCP has started, most (if not all) team members are in agreement label Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@spastorino @nikomatsakis @Mark-Simulacrum @LeSeulArtichaut @rustbot