Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename various internal things #451

Closed
1 of 3 tasks
oli-obk opened this issue Jul 28, 2021 · 3 comments
Closed
1 of 3 tasks

Rename various internal things #451

oli-obk opened this issue Jul 28, 2021 · 3 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@oli-obk
Copy link
Contributor

oli-obk commented Jul 28, 2021 •
edited
Loading

Proposal

There are some things in rustc that are named historically or just really oddly. I would like to rename them to reflect what they are without having to understand Rust's history and/or programming language design/theory jargon.

  • Region -> Lifetime in general. While Region kinda makes more sense, we use Lifetime in the language
  • EarlyBoundRegion -> GenericLifetime (to reflect what they are in the language)
  • LateBoundRegion ->HigherRankedLifetime (")
  • *Folder and fold_* -> *Replacer and replace_*
  • Substs -> GenericArgs
  • subst -> replace_generics

Mentors or Reviewers

@oli-obk, @eddyb

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@oli-obk oli-obk added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Jul 28, 2021
@rustbot
Copy link
Collaborator

rustbot commented Jul 28, 2021

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jul 28, 2021
@eddyb
Copy link
Member

eddyb commented Jul 28, 2021

@rustbot second (specifically, I would prefer if moved past the confusing "folder" and "substs" terminology, feels like it's long overdue - the other changes seem like they don't have to be done at the same time)

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Jul 28, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jul 31, 2021
@apiraino
Copy link
Contributor

@rustbot label -final-comment-period +major-change-accepted

@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Aug 18, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Aug 19, 2021
@oli-obk oli-obk mentioned this issue Apr 12, 2023
Open
6 tasks
@apiraino apiraino mentioned this issue Oct 24, 2023
Closed
3 tasks
@lcnr lcnr mentioned this issue Feb 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eddyb @oli-obk @apiraino @rustbot