Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TyKind::Alias to keep type alias information #504

Closed
1 of 3 tasks
GuillaumeGomez opened this issue Apr 4, 2022 · 3 comments
Closed
1 of 3 tasks

Add TyKind::Alias to keep type alias information #504

GuillaumeGomez opened this issue Apr 4, 2022 · 3 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Apr 4, 2022

Proposal

Motivation

In rustdoc, we have this old issue where foreign type aliases in foreign functions declaration are discarded, only the aliased type remaining.

You can see it by documenting: https://github.com/svartalf/rust-issue-15823

The issue also appears for diagnostics where type aliases can be discarded, making them confusing for developers.

Proposal

After talking about this problem with @oli-obk, they suggested that a new TyAlias variant should be added to the TyKind enum. Similar to associated type projections, this will get resolved to the aliased type during normalization, but for rustdoc and diagnostics we retain the information that this was about a type alias.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@GuillaumeGomez GuillaumeGomez added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Apr 4, 2022
@rustbot
Copy link
Collaborator

rustbot commented Apr 4, 2022

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@oli-obk
Copy link
Contributor

oli-obk commented Apr 7, 2022

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Apr 7, 2022
@oli-obk oli-obk changed the title Add -Zlazily-normalize-type-aliases to keep type alias information Add TyKind::Alias to keep type alias information Apr 7, 2022
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Apr 7, 2022
@apiraino
Copy link
Contributor

@rustbot label -final-comment-period +major-change-accepted

@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Apr 18, 2022
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants