Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Cannot allocate memory" not recognized as OOM #516

Open
RalfJung opened this issue May 21, 2020 · 2 comments
Open

"Cannot allocate memory" not recognized as OOM #516

RalfJung opened this issue May 21, 2020 · 2 comments

Comments

@RalfJung
Copy link
Member

I noticed crater started classifying failures as OOM/ICE, which is awesome. :D
Here's an example that is misclassified as ICE instead: https://crater-reports.s3.amazonaws.com/pr-71796/try%23b2a885c600d942fb829a214e798f7ae205a0594e/gh/GuyL99.pure-core/log.txt

[INFO] [stderr] thread 'rustc' panicked at 'failed to print diagnostics: Os { code: 12, kind: Other, message: "Cannot allocate memory" }', src/librustc_errors/json.rs:110:13
[INFO] [stderr] stack backtrace:
[INFO] [stderr] error: could not compile `nix`.
@pietroalbini
Copy link
Member

Unfortunately that's not a OOM Crater can currently detect. The current detection code checks whether the kernel had to OOMKill a process, while that error is the allocator refusing to allocate more memory.

@Mark-Simulacrum
Copy link
Member

It should be feasible to add "Cannot allocate memory" to the OOM detection though, that seems pretty unlikely to come up as a string otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants