Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crater skips repositories with a Cargo.toml but not Cargo.lock #548

Open
Aaron1011 opened this issue Oct 8, 2020 · 1 comment
Open

Crater skips repositories with a Cargo.toml but not Cargo.lock #548

Aaron1011 opened this issue Oct 8, 2020 · 1 comment

Comments

@Aaron1011
Copy link
Member

When data/github.csv is read, only repositories with both a Cargo.toml and a Cargo.lock are tested:

// Only import repos with a Cargo.toml or Cargo.lock
if !line.has_cargo_toml || !line.has_cargo_lock {
continue;
}

Based on the comment, it looks like the intention was to test repositories with just a Cargo.lock or Cargo.toml as well.

This resulted in a Crater run failing to detect a regression in rust-lang/rust#77718. While Crater cannot be expected to catch all regressions, I think it would be a good idea to test these kinds of repositories. Hopefully, doing so doesn't lead to a significant increase in job run time.

@pietroalbini
Copy link
Member

The intention of that condition was to filter out libraries already published on crates.io, as there is usually little point in testing multiple versions of the same library. I think it's fine to remove the condition if we implement a more advanced one that still filters out crates published on crates.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants