Update max_version if max_version is null when publishing new version

Author: yodaldevoid

src/krate.rs

@@ -385,6 +385,7 @@ impl Crate {
         }
         let zero = semver::Version::parse("0.0.0").unwrap();
         let new_max = match self.max_version {
+            None => true,
             Some(ref max_version) if *ver > *max_version || *max_version == zero => true,
             _ => false,
         };

src/tests/http-data/krate_publish_after_yank_max_version

@@ -0,0 +1,41 @@
+===REQUEST 339
+PUT http://alexcrichton-test.s3.amazonaws.com/crates/fyk_max/fyk_max-1.0.0.crate HTTP/1.1
+Accept: */*
+Proxy-Connection: Keep-Alive
+Authorization: AWS AKIAJF3GEK7N44BACDZA:GDxGb6r3SIqo9wXuzHrgMNWekwk=
+Content-Length: 0
+Host: alexcrichton-test.s3.amazonaws.com
+Content-Type: application/x-tar
+Date: Sun, 28 Jun 2015 14:07:17 -0700
+
+
+===RESPONSE 258
+HTTP/1.1 200
+x-amz-request-id: CB0E925D8E3AB3E8
+x-amz-id-2: SiaMwszM1p2TzXlLauvZ6kRKcUCg7HoyBW29vts42w9ArrLwkJWl8vuvPuGFkpM6XGH+YXN852g=
+date: Sun, 28 Jun 2015 21:07:51 GMT
+etag: "d41d8cd98f00b204e9800998ecf8427e"
+content-length: 0
+server: AmazonS3
+
+
+===REQUEST 339
+PUT http://alexcrichton-test.s3.amazonaws.com/crates/fyk_max/fyk_max-2.0.0.crate HTTP/1.1
+Accept: */*
+Proxy-Connection: Keep-Alive
+Authorization: AWS AKIAJF3GEK7N44BACDZA:GDxGb6r3SIqo9wXuzHrgMNWekwk=
+Content-Length: 0
+Host: alexcrichton-test.s3.amazonaws.com
+Content-Type: application/x-tar
+Date: Sun, 28 Jun 2015 14:07:17 -0700
+
+
+===RESPONSE 258
+HTTP/1.1 200
+x-amz-request-id: CB0E925D8E3AB3E8
+x-amz-id-2: SiaMwszM1p2TzXlLauvZ6kRKcUCg7HoyBW29vts42w9ArrLwkJWl8vuvPuGFkpM6XGH+YXN852g=
+date: Sun, 28 Jun 2015 21:07:51 GMT
+etag: "d41d8cd98f00b204e9800998ecf8427e"
+content-length: 0
+server: AmazonS3
+

src/tests/krate.rs

@@ -958,6 +958,53 @@ fn yank_max_version() {
     assert_eq!(json.krate.max_version.unwrap(), "2.0.0");
 }
 
+#[test]
+fn publish_after_yank_max_version() {
+    #[derive(RustcDecodable)]
+    struct O {
+        ok: bool,
+    }
+    let (_b, app, middle) = ::app();
+
+    // Upload a new crate
+    let mut req = ::new_req(app, "fyk_max", "1.0.0");
+    ::mock_user(&mut req, ::user("foo"));
+    let mut response = ok_resp!(middle.call(&mut req));
+
+    // double check the max version
+    let json: GoodCrate = ::json(&mut response);
+    assert!(json.krate.max_version.is_some());
+    assert_eq!(json.krate.max_version.unwrap(), "1.0.0");
+
+    // yank version 1.0.0
+    let mut r = ok_resp!(middle.call(req.with_method(Method::Delete)
+        .with_path("/api/v1/crates/fyk_max/1.0.0/yank")));
+    assert!(::json::<O>(&mut r).ok);
+    let mut response = ok_resp!(middle.call(req.with_method(Method::Get)
+        .with_path("/api/v1/crates/fyk_max")));
+    let json: CrateResponse = ::json(&mut response);
+    assert!(json.krate.max_version.is_none());
+
+    // add version 2.0.0
+    let body = ::new_req_body_version_2(::krate("fyk_max"));
+    let mut response = ok_resp!(middle.call(req.with_path("/api/v1/crates/new")
+        .with_method(Method::Put)
+        .with_body(&body)));
+    let json: GoodCrate = ::json(&mut response);
+    assert!(json.krate.max_version.is_some());
+    assert_eq!(json.krate.max_version.unwrap(), "2.0.0");
+
+    // unyank version 1.0.0
+    let mut r = ok_resp!(middle.call(req.with_method(Method::Put)
+        .with_path("/api/v1/crates/fyk_max/1.0.0/unyank")));
+    assert!(::json::<O>(&mut r).ok);
+    let mut response = ok_resp!(middle.call(req.with_method(Method::Get)
+        .with_path("/api/v1/crates/fyk_max")));
+    let json: CrateResponse = ::json(&mut response);
+    assert!(json.krate.max_version.is_some());
+    assert_eq!(json.krate.max_version.unwrap(), "2.0.0");
+}
+
 #[test]
 fn bad_keywords() {
     let (_b, app, middle) = ::app();