SQL: Fix metadata handling in to_semver_no_prerelease() function

Author: Turbo87

migrations/2021-09-03-132838_fix_to_semver_no_prerelease/down.sql

@@ -0,0 +1,12 @@
+create or replace function to_semver_no_prerelease(text) returns semver_triple
+    immutable
+    language sql
+as
+$$
+SELECT (
+        split_part($1, '.', 1)::numeric,
+        split_part($1, '.', 2)::numeric,
+        split_part(split_part($1, '+', 1), '.', 3)::numeric
+           )::semver_triple
+WHERE strpos($1, '-') = 0
+$$;

migrations/2021-09-03-132838_fix_to_semver_no_prerelease/up.sql

@@ -0,0 +1,19 @@
+create or replace function to_semver_no_prerelease(text) returns semver_triple
+    immutable
+    language sql
+as
+$$
+SELECT (
+        -- 2) then, we extract the major, minor and patch numbers
+        --    (dropping the prerelease part to avoid number conversion errors)
+        split_part(version_without_metadata, '.', 1)::numeric,
+        split_part(version_without_metadata, '.', 2)::numeric,
+        split_part(split_part(version_without_metadata, '-', 1), '.', 3)::numeric
+           )::semver_triple
+FROM (
+    -- 1) first, we split off the release metadata, if it exists
+    SELECT split_part($1, '+', 1) as version_without_metadata
+    ) as vwm
+-- 3) finally, we only return the result if there is no prerelease part
+WHERE strpos(version_without_metadata, '-') = 0
+$$;

src/tests/sql/custom_functions.rs

@@ -32,4 +32,7 @@ fn to_semver_no_prerelease_works() {
     test(&conn, "1.2.4", Some((1, 2, 4)));
     test(&conn, "1.2.4+metadata", Some((1, 2, 4)));
     test(&conn, "1.2.4-beta.3", None);
+
+    // see https://github.com/rust-lang/crates.io/issues/3882
+    test(&conn, "0.4.45+curl-7.78.0", Some((0, 4, 45)));
 }