Skip to content

Incorrect metadata coming from last published version #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kvark opened this issue May 8, 2018 · 2 comments
Closed

Incorrect metadata coming from last published version #1389

kvark opened this issue May 8, 2018 · 2 comments
Labels
A-backend ⚙️ A-publish C-bug 🐞 Category: unintended, undesired behavior

Comments

@kvark
Copy link

kvark commented May 8, 2018

Case in question: https://crates.io/crates/io-surface

The "Repository" link under "io-surface 0.10.0" at the top is pointing to "https://github.com/servo/io-surface-rs", which is wrong. The repository was moved after 0.9, and the actual Cargo.toml for 0.10.0 has:

homepage = "https://github.com/servo/core-foundation-rs"
repository = "https://github.com/servo/core-foundation-rs"
version = "0.10.0"

@jrmuizel suspects "crates.io" got confused because 0.9.1 was published last. This seems like a bug in the web site.

@sgrif
Copy link
Contributor

sgrif commented May 9, 2018

This sort of metadata is generally attached to the crate, not the version. (The main exception is authors). Currently we always update this when you upload a new version. Since the most recently uploaded version was 0.9.1, we would have used whatever was in that Cargo.toml.

I think you're right that we should probably only update these fields when a version greater than the current max is uploaded, but I'd like to hear other people's thoughts on this. @ashleygwilliams WDYT?

If we do change this behavior, it's not something that would retroactively apply. You will need to upload a new version with the correct metadata no matter what we decide.

@Turbo87
Copy link
Member

Turbo87 commented Sep 26, 2021

It looks like this has been fixed already at some point. https://crates.io/crates/io-surface/0.10.0 is now showing the correct repository link.

@Turbo87 Turbo87 closed this as completed Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ A-publish C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

No branches or pull requests

4 participants