Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send email when a token or co-owner is added #2639

Open
jsha opened this issue Jul 15, 2020 · 2 comments
Open

Send email when a token or co-owner is added #2639

jsha opened this issue Jul 15, 2020 · 2 comments
Labels
A-backend ⚙️ C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works

Comments

@jsha
Copy link
Contributor

jsha commented Jul 15, 2020

In the spirit of #1895, it would be good to notify account holders and crate owners on actions that affect authorization status, like adding an API token to their account or adding a co-owner to a crate they own.

@Turbo87 Turbo87 added the C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works label Feb 11, 2021
@domodwyer
Copy link
Contributor

Hey @Turbo87 I'm happy to finish this ticket off (by adding the "send an email when a co-owner is added" functionality).

Before I do, in #9245 (comment) you said:

we could move sending the email to a background job, but that would be yet another query. this is fine as is for now :)

Would you prefer I implement the new co-owner email as a background job? Or inline with the API call like #9245 does for the token email. If background job, I'll open a PR after to do the same for #9245 too after?

@Turbo87
Copy link
Member

Turbo87 commented Aug 18, 2024

Would you prefer I implement the new co-owner email as a background job?

whatever you prefer/is easier. we don't have strong reasons yet to prefer one over the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

No branches or pull requests

3 participants