Skip to content

Wrong crate name of dependency in old Firefox. #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vi opened this issue Dec 2, 2016 · 7 comments
Closed

Wrong crate name of dependency in old Firefox. #482

vi opened this issue Dec 2, 2016 · 7 comments
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior question ❔

Comments

@vi
Copy link

vi commented Dec 2, 2016

https://crates.io/crates/thrussh

Dependencies

While according to Cargo.toml it should be libsodium-sys.

Note: this is Firefox 38.0.6. In Firefox 45.2.0 and Chromium 53 it shows libsodium-sys like it should.

@vi vi changed the title Wrong crate name dependency (makes seemingly cyclic dependency). Wrong crate name of dependency in old Firefox. Dec 2, 2016
@carols10cents carols10cents added C-bug 🐞 Category: unintended, undesired behavior A-ui labels Dec 15, 2016
@ducks
Copy link

ducks commented Jan 30, 2017

It looks like thrussh dropped the libsodium-sys dep in 0.7.0 but crates.io shows the latest version by default which is 0.8.2.

https://docs.rs/crate/thrussh/0.7.0/source/Cargo.toml
https://crates.io/crates/thrussh/0.7.0

vs

https://docs.rs/crate/thrussh/0.8.2/source/Cargo.toml
https://crates.io/crates/thrussh

@carols10cents
Copy link
Member

So is there a bug here still...?

@vi
Copy link
Author

vi commented Feb 11, 2017

I've checked in Firefox 38.8.0 and it seems to be OK. This page matches in FF 38.8 and FF 45.7.

@carols10cents
Copy link
Member

Ok, I'm going to close this then :)

@jpernst
Copy link

jpernst commented Mar 29, 2017

I still notice this on FF 52.0.1, but it requires an addition step. On any crate page, click the FIRST dependency link to go to its page, then hit back to return to the original crate. The first dep will still have the correct version, but will be named as the crate itself rather than the actual dep. Doing so on any other dependency does not appear to trigger the bug, only the first one will cause it.

@carols10cents
Copy link
Member

@jpernst ooh!!! That is very helpful, thank you!!!!

@carols10cents
Copy link
Member

Ooops we already have an issue for that actually, closing this as a duplicate of #306 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior question ❔
Projects
None yet
Development

No branches or pull requests

5 participants