-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow crate version deletion in the first 24 hours from creation #5301
Conversation
@nappa85 just for awareness: #5293 (comment) tl;dr I'm not sure whether we should allow crate deletion, or if it makes more sense for us to allow version deletion, and then if there is no version left the crate automatically gets deleted too. |
Updated, let me know if there is anything else |
I think there is some work left on correctly syncing both the git and the http index after the deletion. But before we continue, I talked to a few people about this and since it is a quite significant change we might actually require to go through the RFC process for it since other people are currently relying on the fact that crates don't just disappear like that again. |
and just to be clear, I'm very thankful for the quick implementation! I just want to make sure we're not we're not surprising too many people with this change :) |
Understandable, don't worry |
☔ The latest upstream changes (presumably 802f7ec) made this pull request unmergeable. Please resolve the merge conflicts. |
Something nasty happened during the rebase, probably better restart from scratch... |
ac7e9d5
to
c4cf991
Compare
FWIW there is now an RFC for this: rust-lang/rfcs#3660 since the implementation will need a couple of changes (and rebases) I'll close this PR and will use it as inspiration when implementing the RFC spec :) |
Adds route DELETE /api/v1/crates/:crate_id
Resolves #5293