Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow crate version deletion in the first 24 hours from creation #5301

Closed
wants to merge 1 commit into from

Conversation

nappa85
Copy link

@nappa85 nappa85 commented Oct 8, 2022

Adds route DELETE /api/v1/crates/:crate_id

Resolves #5293

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-backend ⚙️ labels Oct 8, 2022
@nappa85 nappa85 changed the title WIP: Allow crate deletion in the first 24 hours from creation Allow crate deletion in the first 24 hours from creation Oct 9, 2022
@Turbo87
Copy link
Member

Turbo87 commented Oct 9, 2022

@nappa85 just for awareness: #5293 (comment)

tl;dr I'm not sure whether we should allow crate deletion, or if it makes more sense for us to allow version deletion, and then if there is no version left the crate automatically gets deleted too.

@nappa85 nappa85 changed the title Allow crate deletion in the first 24 hours from creation Allow crate version deletion in the first 24 hours from creation Oct 10, 2022
@nappa85
Copy link
Author

nappa85 commented Oct 10, 2022

@nappa85 just for awareness: #5293 (comment)

tl;dr I'm not sure whether we should allow crate deletion, or if it makes more sense for us to allow version deletion, and then if there is no version left the crate automatically gets deleted too.

Updated, let me know if there is anything else

@Turbo87
Copy link
Member

Turbo87 commented Oct 13, 2022

I think there is some work left on correctly syncing both the git and the http index after the deletion. But before we continue, I talked to a few people about this and since it is a quite significant change we might actually require to go through the RFC process for it since other people are currently relying on the fact that crates don't just disappear like that again.

@Turbo87
Copy link
Member

Turbo87 commented Oct 13, 2022

and just to be clear, I'm very thankful for the quick implementation! I just want to make sure we're not we're not surprising too many people with this change :)

@nappa85
Copy link
Author

nappa85 commented Oct 13, 2022

and just to be clear, I'm very thankful for the quick implementation! I just want to make sure we're not we're not surprising too many people with this change :)

Understandable, don't worry

@bors
Copy link
Contributor

bors commented Jan 3, 2023

☔ The latest upstream changes (presumably 802f7ec) made this pull request unmergeable. Please resolve the merge conflicts.

@nappa85
Copy link
Author

nappa85 commented Feb 3, 2023

Something nasty happened during the rebase, probably better restart from scratch...

@Turbo87
Copy link
Member

Turbo87 commented Jul 12, 2024

FWIW there is now an RFC for this: rust-lang/rfcs#3660

since the implementation will need a couple of changes (and rebases) I'll close this PR and will use it as inspiration when implementing the RFC spec :)

@Turbo87 Turbo87 closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ B-needs-rfc C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow deletion of crates within 24 hours of publishing
3 participants