-
Notifications
You must be signed in to change notification settings - Fork 642
Show build status for the relevant version, rather than master #743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Also pointed out in the meeting: the status of the tag build likely is from when the tag was created, and doesn't show that the version could compile on current stable Rust. |
This is already doable via the |
Oh but manually writing the crate version in multiple places is a bummer. It's the same complaint we had with html_root_url rust-lang/rust#42300. 😿 |
Right, but that's a Cargo issue, not a crates.io issue IMO |
See rust-lang/cargo#2075, a full implementation of that feature (IMO) would cover this as well and allow the |
I don't think this feature would be useful; released versions should always be passing on CI. The CI badges are more of an indication of the general health of the project and a signal of active maintenance. Also please see #540; it's a feature we hope to incorporate soon that allows crate authors to set up reporting of build status of released versions on different rust versions and targets, which I do think is useful. |
In this instance, I disagree. When reqwest v1.0 is released, and someone visits its crate page, it should show that v1.0 passed CI. As work on reqwest master continues, and inevitably something causes the build to fail, it would be quite damaging to show a CI failed badge on the crate page, even though 1.0 did pass. Perhaps #540 better captures this idea, I haven't had time to digest it. |
Currently the most recent version of serde is 1.0.8. As such, https://crates.io/crates/serde should show build status for 1.0.8 rather than master.
Similarly, https://crates.io/crates/serde/1.0.7 should show build status for 1.0.7.
Different projects use different naming schemes for their tags, so we would need to insist on one particular scheme or allow it to be configurable.
This came up during the libs team discussion of reqwest. cc @seanmonstar @sfackler
The text was updated successfully, but these errors were encountered: