Skip to content

Show build status for the relevant version, rather than master #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dtolnay opened this issue May 31, 2017 · 7 comments
Closed

Show build status for the relevant version, rather than master #743

dtolnay opened this issue May 31, 2017 · 7 comments

Comments

@dtolnay
Copy link
Member

dtolnay commented May 31, 2017

Currently the most recent version of serde is 1.0.8. As such, https://crates.io/crates/serde should show build status for 1.0.8 rather than master.

- https://api.travis-ci.org/serde-rs/serde.svg?branch=master
+ https://api.travis-ci.org/serde-rs/serde.svg?branch=v1.0.8

Similarly, https://crates.io/crates/serde/1.0.7 should show build status for 1.0.7.

Different projects use different naming schemes for their tags, so we would need to insist on one particular scheme or allow it to be configurable.

This came up during the libs team discussion of reqwest. cc @seanmonstar @sfackler

@seanmonstar
Copy link
Contributor

Also pointed out in the meeting: the status of the tag build likely is from when the tag was created, and doesn't show that the version could compile on current stable Rust.

@sfackler
Copy link
Member

This is already doable via the branch field in the config struct in Cargo.toml.

@dtolnay
Copy link
Member Author

dtolnay commented May 31, 2017

Oh but manually writing the crate version in multiple places is a bummer. It's the same complaint we had with html_root_url rust-lang/rust#42300. 😿

@sfackler
Copy link
Member

Right, but that's a Cargo issue, not a crates.io issue IMO

@Nemo157
Copy link
Member

Nemo157 commented May 31, 2017

See rust-lang/cargo#2075, a full implementation of that feature (IMO) would cover this as well and allow the branch field to be based off the "single source of truth for crate versions".

@carols10cents
Copy link
Member

carols10cents commented Jun 6, 2017

I don't think this feature would be useful; released versions should always be passing on CI. The CI badges are more of an indication of the general health of the project and a signal of active maintenance.

Also please see #540; it's a feature we hope to incorporate soon that allows crate authors to set up reporting of build status of released versions on different rust versions and targets, which I do think is useful.

@seanmonstar
Copy link
Contributor

I don't think this feature would be useful; released versions should always be passing on CI. The CI badges are more of an indication of the general health of the project and a signal of active maintenance.

In this instance, I disagree. When reqwest v1.0 is released, and someone visits its crate page, it should show that v1.0 passed CI. As work on reqwest master continues, and inevitably something causes the build to fail, it would be quite damaging to show a CI failed badge on the crate page, even though 1.0 did pass.

Perhaps #540 better captures this idea, I haven't had time to digest it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants