Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report a Crate isn't working #9949

Open
blueglyph opened this issue Nov 15, 2024 · 6 comments
Open

Report a Crate isn't working #9949

blueglyph opened this issue Nov 15, 2024 · 6 comments
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior

Comments

@blueglyph
Copy link

Current Behavior

Clicking on the Report crate button opens the form as expected, with the name of the crate, the reason, and optional details. But when I click on the Report button at the bottom,

  • with Firefox, it opens a new blank browser window
  • with Brave, it does nothing at all

Expected Behavior

The report is sent and a confirmation is shown; for example with a pop-up or by displaying a new confirmation page.

Steps To Reproduce

Environment

  • Browser: Brave (1.73.89), Firefox (132.0.1)
  • OS: Windows 10 x64

Anything else?

I didn't see any specific instruction or requirement, e.g. to be either logged in or not. I tried both, but it didn't seem to make any difference. I disabled my uBlock plugin, but it didn't make any difference, either.

Perhaps it's simply not giving any feedback and the report is sent anyway, and perhaps Firefox opening a new browser is a side-effect? Hard to know. Or perhaps it's only a placeholder for the functionality to come?

There's very little explanation about it, so I assumed it was a regular report feature.

@Turbo87
Copy link
Member

Turbo87 commented Nov 15, 2024

The "Report" button on that page essentially generates a mailto: link and is supposed to open that link in a new tab. Not sure what happened in your case.

@eth3lbert any ideas?

@Turbo87 Turbo87 added C-bug 🐞 Category: unintended, undesired behavior A-frontend 🐹 labels Nov 15, 2024
@blueglyph
Copy link
Author

Oh. I would have never expected that; I haven't used an email client for about 20 years. But I remember those mailto-generated forms, now.

I assume you don't want to use a database to store the reports. Using emails is fine, but requiring users to have an email client is a little awkward, since a lot of them don't have any, these days. Is there an alternative way to send an email with the report?

@Turbo87
Copy link
Member

Turbo87 commented Nov 15, 2024

I assume you don't want to use a database to store the reports.

we need a way to respond to reports, so email seems more suited

requiring users to have an email client is a little awkward, since a lot of them don't have any, these days

yeah, that is a fair point. Firefox is able to use in-browser Gmail with mailto: links, but it seems that they don't support any other providers.

Is there an alternative way to send an email with the report?

you can send a regular email to help@crates.io

@eth3lbert
Copy link
Contributor

Here is the template we used:

To: help@crates.io
Subject: The `crate name` crate

Content:
I'm reporting the `link to the crate on crates.io` crate because:

- [ ] it contains spam
- [x] it is name-squatting (reserving a crate name without content)
- [ ] it is abusive or otherwise harmful
- [ ] it contains a vulnerability (please try to contact the crate author first)
- [ ] it is violating the usage policy in some other way (please specify below)

Additional details:

@eth3lbert
Copy link
Contributor

The "Report" button on that page essentially generates a mailto: link and is supposed to open that link in a new tab. Not sure what happened in your case.

@eth3lbert any ideas?

All reported issues about the support page (crate report) are currently related to email clients or URL scheme handlers. I assume that most users should work fine with the current implementation. However, we could revisit this if we see a significant number of users experiencing issues.

@blueglyph
Copy link
Author

All reported issues about the support page (crate report) are currently related to email clients or URL scheme handlers. I assume that most users should work fine with the current implementation. However, we could revisit this if we see a significant number of users experiencing issues.

By looking more around Firefox, I found that it was possible to configure how to handle mailto:, including a way to link it to Gmail. I'm not sure if it's possible with other providers like ProtonMail, but Gmail would be fine for most (about 33% users, another 50% coming from Apple Mail, apparently, and the rest being small percentages of various methods). After I configured it for Gmail, clicking on Report opens the Gmail login page.

However, I'm currently using Brave, which doesn't seem to have any handler configuration. I reported the problem there, but a few posts I found suggested that the Mail app should be configured as default app in Windows, so that's limited to clients (unless there's a trick I don't know).

In conclusion: it works with some browsers, but it's not standard. People who don't use a client must use a browser that allows for customizing the mailto: handler.

Since "mail-less" reports are the norm, I'd still suggest to make the user aware it's email-based to avoid any confusion. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

No branches or pull requests

3 participants