Log and return 500 for other errors

Author: Nemo157

src/web/error.rs

@@ -10,6 +10,7 @@ pub enum Nope {
     ResourceNotFound,
     CrateNotFound,
     NoResults,
+    InternalServerError,
 }
 
 impl fmt::Display for Nope {
@@ -18,6 +19,7 @@ impl fmt::Display for Nope {
             Nope::ResourceNotFound => "Requested resource not found",
             Nope::CrateNotFound => "Requested crate not found",
             Nope::NoResults => "Search yielded no results",
+            Nope::InternalServerError => "Internal server error",
         })
     }
 }
@@ -59,6 +61,13 @@ impl Handler for Nope {
                         .to_resp("releases")
                 }
             }
+            Nope::InternalServerError => {
+                // something went wrong, details should have been logged
+                Page::new("internal server error".to_owned())
+                    .set_status(status::InternalServerError)
+                    .title("Internal server error")
+                    .to_resp("error")
+            }
         }
     }
 }

src/web/mod.rs

@@ -159,10 +159,21 @@ impl Handler for CratesfyiHandler {
             .or_else(|e| {
                 let err = if let Some(err) = e.error.downcast::<error::Nope>() {
                     *err
-                } else if e.error.downcast::<NoRoute>().is_some() {
+                } else if e.error.downcast::<NoRoute>().is_some()
+                    || e.response.status == Some(status::NotFound)
+                {
                     error::Nope::ResourceNotFound
+                } else if e.response.status == Some(status::InternalServerError) {
+                    log::error!("internal server error: {}", e.error);
+                    error::Nope::InternalServerError
                 } else {
-                    panic!("all cratesfyi errors should be of type Nope");
+                    log::error!(
+                        "No error page for status {:?}; {}",
+                        e.response.status,
+                        e.error
+                    );
+                    // TODO: add in support for other errors that are actually used
+                    error::Nope::InternalServerError
                 };
 
                 if let error::Nope::ResourceNotFound = err {
@@ -186,7 +197,7 @@ impl Handler for CratesfyiHandler {
                         }
                     }
 
-                    debug!("Path not found: {}", DebugPath(&req.url));
+                    debug!("Path not found: {}; {}", DebugPath(&req.url), e.error);
                 }
 
                 Self::chain(self.pool.clone(), err).handle(req)