Skip to content

Commit 1943e68

Browse files
committed
allow longer crate names & versions in build queue
1 parent d4641c3 commit 1943e68

6 files changed

+50
-6
lines changed

.sqlx/query-43d0bb3b88356af3abdae506b7699ec762a6f1debbbda49a3479fddaa8917e17.json

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.sqlx/query-b2266a1d32ffedec1b35d94404d3747632ee3144ebe16cfa11d852f73a4ebbff.json

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.sqlx/query-ebb47544b1090567139f3bdf2c22993c3a3aaef41c6520095a2c3bfaf6035da6.json

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
DELETE FROM queue WHERE LENGTH(name) > 255 OR LENGTH(version) > 100;
2+
3+
ALTER TABLE queue
4+
ALTER COLUMN name TYPE VARCHAR(255),
5+
ALTER COLUMN version TYPE VARCHAR(100);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
ALTER TABLE queue
2+
ALTER COLUMN name TYPE TEXT,
3+
ALTER COLUMN version TYPE TEXT;

src/build_queue.rs

+36
Original file line numberDiff line numberDiff line change
@@ -1155,4 +1155,40 @@ mod tests {
11551155
Ok(())
11561156
});
11571157
}
1158+
1159+
#[test]
1160+
fn test_add_long_name() {
1161+
crate::test::wrapper(|env| {
1162+
let queue = env.build_queue();
1163+
1164+
let name: String = "krate".repeat(100);
1165+
1166+
queue.add_crate(&name, "0.0.1", 0, None)?;
1167+
1168+
queue.process_next_crate(|krate| {
1169+
assert_eq!(name, krate.name);
1170+
Ok(BuildPackageSummary::default())
1171+
})?;
1172+
1173+
Ok(())
1174+
})
1175+
}
1176+
1177+
#[test]
1178+
fn test_add_long_version() {
1179+
crate::test::wrapper(|env| {
1180+
let queue = env.build_queue();
1181+
1182+
let version: String = "version".repeat(100);
1183+
1184+
queue.add_crate("krate", &version, 0, None)?;
1185+
1186+
queue.process_next_crate(|krate| {
1187+
assert_eq!(version, krate.version);
1188+
Ok(BuildPackageSummary::default())
1189+
})?;
1190+
1191+
Ok(())
1192+
})
1193+
}
11581194
}

0 commit comments

Comments
 (0)