Skip to content

"Platform" button unresponsive with no targets #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
XAMPPRocky opened this issue Oct 22, 2020 · 1 comment · Fixed by #1136
Closed

"Platform" button unresponsive with no targets #1111

XAMPPRocky opened this issue Oct 22, 2020 · 1 comment · Fixed by #1136
Labels
A-frontend Area: Web frontend C-bug Category: This is a bug E-easy Effort: Should be easy to implement and would make a good first PR mentor This has instructions for getting started

Comments

@XAMPPRocky
Copy link
Member

The platform button in the navbar currently gives no feedback if there are no platforms. I feel it would more appropriate to display something or hide the button entirely.

@jyn514 jyn514 added A-frontend Area: Web frontend C-bug Category: This is a bug labels Oct 22, 2020
@jyn514
Copy link
Member

jyn514 commented Oct 22, 2020

Mentoring instructions: In

{# If there are platforms, show a dropdown with them #}
{%- if platforms -%}

check whether platforms is empty, not whether it is truthy. https://tera.netlify.app/docs/#control-structures

@jyn514 jyn514 added E-easy Effort: Should be easy to implement and would make a good first PR mentor This has instructions for getting started labels Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Area: Web frontend C-bug Category: This is a bug E-easy Effort: Should be easy to implement and would make a good first PR mentor This has instructions for getting started
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants