Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ring+nightly issue #1721

Closed
CriesofCarrots opened this issue Apr 11, 2022 · 6 comments
Closed

Ring+nightly issue #1721

CriesofCarrots opened this issue Apr 11, 2022 · 6 comments

Comments

@CriesofCarrots
Copy link

CriesofCarrots commented Apr 11, 2022

Crate name

solana-client, but other crates also affected.

Build failure link

https://docs.rs/crate/solana-client/1.10.4, https://docs.rs/crate/solana-client/1.9.14

Additional details

Solana monorepo v1.9.14 and v1.10.4 docs were affected by this issue: briansmith/ring#1469
Is there a way we can go through and queue the failures for rebuild?

@syphar
Copy link
Member

syphar commented Apr 12, 2022

@CriesofCarrots I just queued both releases, see https://docs.rs/releases/queue .

@Nemo157 was scraping the logs for failures ( see #1703 (comment) ) and somehow this slipped through.

@CriesofCarrots
Copy link
Author

Great, thank you, @syphar and @Nemo157 !
I think some of the other solana- crates may be affected, but I haven't audited yet. May I comment them here as I find them?

@syphar
Copy link
Member

syphar commented Apr 12, 2022

May I comment them here as I find them?

Yeah, that I can definitely do

@CriesofCarrots
Copy link
Author

It looks like most of the crates in our v1.9.14 and v1.10.4 releases were affected, but here are the ones I'm most interested in having rebuilt, if possible:
solana-cli
solana-core
solana-geyser-plugin-interface
solana-geyser-plugin-manager
solana-gossip
solana-ledger
solana-program-test
solana-rpc
solana-test-validator
solana-validator

It looks like there's a different docs build issue with the v1.9.15 and v1.10.7+ versions of most of those crates; I assume it's our bug.

Anyway, thank you!

@syphar
Copy link
Member

syphar commented Apr 13, 2022

@CriesofCarrots I just queued both versions for all these crates, see https://docs.rs/releases/queue

@syphar
Copy link
Member

syphar commented Jan 11, 2023

I assume the builds are fine now.

Feel free to reopen this issue if not.

@syphar syphar closed this as completed Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants