Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalidate pages when release is yanked #1862

Closed
jsha opened this issue Sep 29, 2022 · 2 comments · Fixed by #1864
Closed

invalidate pages when release is yanked #1862

jsha opened this issue Sep 29, 2022 · 2 comments · Fixed by #1864

Comments

@jsha
Copy link
Contributor

jsha commented Sep 29, 2022

Part of #1552, filing as its own issue so we don't forget:

When a crate version is yanked, we should create an invalidation for that crate.

Note: I looked to see how / when we get information about yanks. It looks like it happens in index::Api::get_release_data. But that appears to only get called during builds. Is that right?

@Nemo157
Copy link
Member

Nemo157 commented Sep 29, 2022

Yanks get detected by the "registry watcher" here:

Change::Yanked(release) => {

@syphar
Copy link
Member

syphar commented Sep 29, 2022

This is definitely a gap in the current logic, probably + a crate-delete event.

I would fix this after we merged #1856, but before we introduce the default TTL ( = before we actually start caching)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants