Skip to content

It failed to build bindings crate #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thewh1teagle opened this issue Oct 25, 2024 · 2 comments
Closed

It failed to build bindings crate #2654

thewh1teagle opened this issue Oct 25, 2024 · 2 comments

Comments

@thewh1teagle
Copy link

Crate name

sherpa-rs

Build failure link

https://docs.rs/crate/sherpa-rs/0.5.1/builds/1404232

Additional details

Looks like the build script can't download file from Github.
By default the download-binaries feature enabled for fast build. It downloads prebuilt c++ library and link it.
Though, when I disabled it, it also failed to build on docs.rs.

By the way I can build it locally. is there a way to manually upload the docs to docs.rs?

@syphar
Copy link
Member

syphar commented Oct 28, 2024

Please check out our documentation page about the build environment: https://docs.rs/about/builds.

Specifically network access won't be allowed generally.

The most used options currently possible are you vendoring the needed files into your crate, or use conditional compilation to let the docs build without the need for the external library.

Uploading your own docs is not possible right now, we're tracking this request in #93. A bunch of questions in there are unanswered, especially on how to prevent malicious docs to be uploaded.

@syphar syphar closed this as not planned Won't fix, can't repro, duplicate, stale Oct 28, 2024
@thewh1teagle
Copy link
Author

The solution was to check DOCS_RS env variable and avoid build anything except the bindings with bindgen.

https://github.com/thewh1teagle/sherpa-rs/blob/66119f8f281a7fbd2ab0b04e0152fcbee553dfde/crates/sherpa-rs-sys/build.rs#L319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants