Skip to content

'rustfmt' is not installed for the toolchain #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidli2010 opened this issue Jun 15, 2020 · 3 comments
Closed

'rustfmt' is not installed for the toolchain #836

davidli2010 opened this issue Jun 15, 2020 · 3 comments
Labels
C-build-failure Category: This is a crate that failed to build

Comments

@davidli2010
Copy link

Crate name: etcd-client
Build failure link: https://docs.rs/crate/etcd-client/0.5.1/builds/261250

Additional details: 'rustfmt' is not installed for the toolchain 'nightly-2020-06-11-x86_64-unknown-linux-gnu'

@davidli2010 davidli2010 added the C-build-failure Category: This is a crate that failed to build label Jun 15, 2020
@Nemo157
Copy link
Member

Nemo157 commented Jun 15, 2020

See also #357

I would highly recommend not making rustfmt a hard-dependency of your crate, not every developer will have it installed, and especially not on CI systems. If you look at how bindgen handles it they just log and output the unformatted code if rustfmt is not available.

@davidli2010
Copy link
Author

Thank you! My crate depends on tonic, and it enables rustfmt by default. I will disable it.

@Nemo157
Copy link
Member

Nemo157 commented Jun 15, 2020

It might be worth opening an issue on tonic to have a fallback when rustfmt isn't available like bindgen, so that you get nicer generated code when possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-build-failure Category: This is a crate that failed to build
Projects
None yet
Development

No branches or pull requests

2 participants