Skip to content

self-host all static content #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Nemo157 opened this issue Jul 31, 2020 · 3 comments · Fixed by #1255
Closed

self-host all static content #921

Nemo157 opened this issue Jul 31, 2020 · 3 comments · Fixed by #1255
Labels
A-backend Area: Webserver backend E-easy Effort: Should be easy to implement and would make a good first PR P-low Low priority issues

Comments

@Nemo157
Copy link
Member

Nemo157 commented Jul 31, 2020

Currently we use some libraries hosted on cdnjs (run by Cloudflare)

docs.rs/templates/base.html

Lines 12 to 17 in 664577a

<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/pure/0.6.0/pure-min.css" type="text/css"
media="all" />
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/pure/0.6.0/grids-responsive-min.css"
type="text/css" media="all" />
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.6.3/css/font-awesome.min.css"
type="text/css" media="all" />

This has caused issues at least once. To reduce our points of failure it might be worth self-hosting these files.
@pietroalbini
Copy link
Member

Yeah, I'd go for it.

@jyn514 jyn514 changed the title Should we self-host all static content self-host all static content Jul 31, 2020
@jyn514 jyn514 added A-backend Area: Webserver backend E-easy Effort: Should be easy to implement and would make a good first PR P-low Low priority issues labels Jul 31, 2020
@Nemo157 Nemo157 mentioned this issue Aug 12, 2020
Closed
@jyn514 jyn514 mentioned this issue Aug 16, 2020
Closed
@Kixiron Kixiron mentioned this issue Aug 16, 2020
Merged
@jyn514
Copy link
Member

jyn514 commented Aug 21, 2020

Implemented in #981

@jyn514 jyn514 closed this as completed Aug 21, 2020
@Kixiron
Copy link
Member

Kixiron commented Aug 21, 2020

We still don't self-host everything, but it did drastically reduce what we don't. hightlight.js (js, css) are still not self-hosted, but they're more additive and aren't critical to site functionality

@Kixiron Kixiron reopened this Aug 21, 2020
@jyn514 jyn514 mentioned this issue Oct 22, 2020
Closed
@pietroalbini pietroalbini mentioned this issue Jan 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-backend Area: Webserver backend E-easy Effort: Should be easy to implement and would make a good first PR P-low Low priority issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to chart.js for the release activity page pietroalbini/docs.rs
4 participants
@Nemo157 @pietroalbini @jyn514 @Kixiron