Skip to content

Avoid creating two <title>s #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kestrer opened this issue Aug 15, 2020 · 1 comment · Fixed by #972
Closed

Avoid creating two <title>s #971

Kestrer opened this issue Aug 15, 2020 · 1 comment · Fixed by #972
Assignees
Labels
A-frontend Area: Web frontend C-bug Category: This is a bug E-easy Effort: Should be easy to implement and would make a good first PR mentor This has instructions for getting started P-medium Medium priority

Comments

@Kestrer
Copy link
Contributor

Kestrer commented Aug 15, 2020

docs.rs creates two titles for most pages, the Rustdoc title and docs.rs title:

two-titles

This is invalid HTML and causes my browser to sometimes just display the URL on the titlebar, since it doesn't know which title to use.

I would actually prefer to use just the Rustdoc title because it provides more information about the site.

@jyn514 jyn514 added A-frontend Area: Web frontend C-bug Category: This is a bug E-easy Effort: Should be easy to implement and would make a good first PR mentor This has instructions for getting started P-medium Medium priority labels Aug 15, 2020
@jyn514
Copy link
Member

jyn514 commented Aug 15, 2020

This is fallout from #930. If we're just using the rustdoc title this should be pretty easy, just remove this line:

<title>{{ macros::doc_title(name=krate.name, version=krate.version) }}</title>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Area: Web frontend C-bug Category: This is a bug E-easy Effort: Should be easy to implement and would make a good first PR mentor This has instructions for getting started P-medium Medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants