Skip to content

Commit 60bcaed

Browse files
author
Harry Barber
committed
Remove IntoFuture in trait bounds
1 parent a88e110 commit 60bcaed

File tree

4 files changed

+20
-23
lines changed

4 files changed

+20
-23
lines changed

futures-util/src/future/try_future/mod.rs

+12-12
Original file line numberDiff line numberDiff line change
@@ -89,15 +89,15 @@ delegate_all!(
8989
delegate_all!(
9090
/// Future for the [`inspect_ok`](super::TryFutureExt::inspect_ok) method.
9191
InspectOk<Fut, F>(
92-
Inspect<IntoFuture<Fut>, InspectOkFn<F>>
93-
): Debug + Future + FusedFuture + New[|x: Fut, f: F| Inspect::new(IntoFuture::new(x), inspect_ok_fn(f))]
92+
Inspect<Fut, InspectOkFn<F>>
93+
): Debug + Future + FusedFuture + New[|x: Fut, f: F| Inspect::new(x, inspect_ok_fn(f))]
9494
);
9595

9696
delegate_all!(
9797
/// Future for the [`inspect_err`](super::TryFutureExt::inspect_err) method.
9898
InspectErr<Fut, F>(
99-
Inspect<IntoFuture<Fut>, InspectErrFn<F>>
100-
): Debug + Future + FusedFuture + New[|x: Fut, f: F| Inspect::new(IntoFuture::new(x), inspect_err_fn(f))]
99+
Inspect<Fut, InspectErrFn<F>>
100+
): Debug + Future + FusedFuture + New[|x: Fut, f: F| Inspect::new(x, inspect_err_fn(f))]
101101
);
102102

103103
#[allow(unreachable_pub)] // https://github.com/rust-lang/rust/issues/57411
@@ -106,29 +106,29 @@ pub use self::into_future::IntoFuture;
106106
delegate_all!(
107107
/// Future for the [`map_ok`](TryFutureExt::map_ok) method.
108108
MapOk<Fut, F>(
109-
Map<IntoFuture<Fut>, MapOkFn<F>>
110-
): Debug + Future + FusedFuture + New[|x: Fut, f: F| Map::new(IntoFuture::new(x), map_ok_fn(f))]
109+
Map<Fut, MapOkFn<F>>
110+
): Debug + Future + FusedFuture + New[|x: Fut, f: F| Map::new(x, map_ok_fn(f))]
111111
);
112112

113113
delegate_all!(
114114
/// Future for the [`map_err`](TryFutureExt::map_err) method.
115115
MapErr<Fut, F>(
116-
Map<IntoFuture<Fut>, MapErrFn<F>>
117-
): Debug + Future + FusedFuture + New[|x: Fut, f: F| Map::new(IntoFuture::new(x), map_err_fn(f))]
116+
Map<Fut, MapErrFn<F>>
117+
): Debug + Future + FusedFuture + New[|x: Fut, f: F| Map::new(x, map_err_fn(f))]
118118
);
119119

120120
delegate_all!(
121121
/// Future for the [`map_ok_or_else`](TryFutureExt::map_ok_or_else) method.
122122
MapOkOrElse<Fut, F, G>(
123-
Map<IntoFuture<Fut>, MapOkOrElseFn<F, G>>
124-
): Debug + Future + FusedFuture + New[|x: Fut, f: F, g: G| Map::new(IntoFuture::new(x), map_ok_or_else_fn(f, g))]
123+
Map<Fut, MapOkOrElseFn<F, G>>
124+
): Debug + Future + FusedFuture + New[|x: Fut, f: F, g: G| Map::new(x, map_ok_or_else_fn(f, g))]
125125
);
126126

127127
delegate_all!(
128128
/// Future for the [`unwrap_or_else`](TryFutureExt::unwrap_or_else) method.
129129
UnwrapOrElse<Fut, F>(
130-
Map<IntoFuture<Fut>, UnwrapOrElseFn<F>>
131-
): Debug + Future + FusedFuture + New[|x: Fut, f: F| Map::new(IntoFuture::new(x), unwrap_or_else_fn(f))]
130+
Map<Fut, UnwrapOrElseFn<F>>
131+
): Debug + Future + FusedFuture + New[|x: Fut, f: F| Map::new(x, unwrap_or_else_fn(f))]
132132
);
133133

134134
impl<Fut: ?Sized + TryFuture> TryFutureExt for Fut {}

futures-util/src/future/try_join_all.rs

+4-5
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,10 @@ use core::mem;
1010
use core::pin::Pin;
1111
use core::task::{Context, Poll};
1212

13-
use super::{assert_future, join_all, IntoFuture, TryFuture, TryMaybeDone};
13+
use super::{assert_future, join_all, TryFuture, TryMaybeDone};
1414

1515
#[cfg(not(futures_no_atomic_cas))]
1616
use crate::stream::{FuturesOrdered, TryCollect, TryStreamExt};
17-
use crate::TryFutureExt;
1817

1918
enum FinalState<E = ()> {
2019
Pending,
@@ -36,11 +35,11 @@ where
3635
F: TryFuture,
3736
{
3837
Small {
39-
elems: Pin<Box<[TryMaybeDone<IntoFuture<F>>]>>,
38+
elems: Pin<Box<[TryMaybeDone<F>]>>,
4039
},
4140
#[cfg(not(futures_no_atomic_cas))]
4241
Big {
43-
fut: TryCollect<FuturesOrdered<IntoFuture<F>>, Vec<F::Ok>>,
42+
fut: TryCollect<FuturesOrdered<F>, Vec<F::Ok>>,
4443
},
4544
}
4645

@@ -119,7 +118,7 @@ where
119118
I: IntoIterator,
120119
I::Item: TryFuture,
121120
{
122-
let iter = iter.into_iter().map(TryFutureExt::into_future);
121+
let iter = iter.into_iter();
123122

124123
#[cfg(futures_no_atomic_cas)]
125124
{

futures-util/src/stream/try_stream/try_buffer_unordered.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
use crate::future::{IntoFuture, TryFutureExt};
21
use crate::stream::{Fuse, FuturesUnordered, IntoStream, StreamExt};
32
use core::num::NonZeroUsize;
43
use core::pin::Pin;
@@ -19,7 +18,7 @@ pin_project! {
1918
{
2019
#[pin]
2120
stream: Fuse<IntoStream<St>>,
22-
in_progress_queue: FuturesUnordered<IntoFuture<St::Ok>>,
21+
in_progress_queue: FuturesUnordered<St::Ok>,
2322
max: Option<NonZeroUsize>,
2423
}
2524
}
@@ -54,7 +53,7 @@ where
5453
// our queue of futures. Propagate errors from the stream immediately.
5554
while this.max.map(|max| this.in_progress_queue.len() < max.get()).unwrap_or(true) {
5655
match this.stream.as_mut().poll_next(cx)? {
57-
Poll::Ready(Some(fut)) => this.in_progress_queue.push(fut.into_future()),
56+
Poll::Ready(Some(fut)) => this.in_progress_queue.push(fut),
5857
Poll::Ready(None) | Poll::Pending => break,
5958
}
6059
}

futures-util/src/stream/try_stream/try_buffered.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
use crate::future::{IntoFuture, TryFutureExt};
21
use crate::stream::{Fuse, FuturesOrdered, IntoStream, StreamExt};
32
use core::num::NonZeroUsize;
43
use core::pin::Pin;
@@ -20,7 +19,7 @@ pin_project! {
2019
{
2120
#[pin]
2221
stream: Fuse<IntoStream<St>>,
23-
in_progress_queue: FuturesOrdered<IntoFuture<St::Ok>>,
22+
in_progress_queue: FuturesOrdered<St::Ok>,
2423
max: Option<NonZeroUsize>,
2524
}
2625
}
@@ -55,7 +54,7 @@ where
5554
// our queue of futures. Propagate errors from the stream immediately.
5655
while this.max.map(|max| this.in_progress_queue.len() < max.get()).unwrap_or(true) {
5756
match this.stream.as_mut().poll_next(cx)? {
58-
Poll::Ready(Some(fut)) => this.in_progress_queue.push_back(fut.into_future()),
57+
Poll::Ready(Some(fut)) => this.in_progress_queue.push_back(fut),
5958
Poll::Ready(None) | Poll::Pending => break,
6059
}
6160
}

0 commit comments

Comments
 (0)