Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compat into_inner methods #1704

Closed
VictorKoenders opened this issue Jul 2, 2019 · 1 comment · Fixed by #1705
Closed

compat into_inner methods #1704

VictorKoenders opened this issue Jul 2, 2019 · 1 comment · Fixed by #1705

Comments

@VictorKoenders
Copy link
Contributor

I'm running into an issue where I'm wrapping a tokio TcpStream's WriteHalf in a Compat01As03Sink and a ReadHalf in a Compat01As03. Later in the function I want to upgrade this TcpStream to a TlsStream. For this, I want to use tokio's SplitStream::reunite. However, because the sink and stream are wrapped in the compat layer, I cannot get an instance back of the original sink and stream. Is there a reason against implementing an into_inner() method for the Compat01As03[Sink] structs?
@Nemo157
Copy link
Member

Nemo157 commented Jul 2, 2019

No reason not to, they should all have the into_inner, get_ref andget_mut trio.

@VictorKoenders VictorKoenders mentioned this issue Jul 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Compat wrapper methods
2 participants
@Nemo157 @VictorKoenders