Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Sink::SinkError to just Sink::Error #1707

Closed
seanmonstar opened this issue Jul 2, 2019 · 0 comments · Fixed by #1708
Closed

Rename Sink::SinkError to just Sink::Error #1707

seanmonstar opened this issue Jul 2, 2019 · 0 comments · Fixed by #1708

Comments

@seanmonstar
Copy link
Contributor

It was originally made SinkError so that implementations that required a generic to be both Stream and Sink could more easily distinguish error types. However, it's possible to disambiguate using <S as Sink<Item>>::Error in an impl (and even temporary generics can be used), and it otherwise reads as a stutter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename Sink::SinkError to Sink::Error seanmonstar/futures-rs
1 participant
@seanmonstar