Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Question] Why doesn't oneshot::Receiver implement FusedFuture? #2298

Closed
TheButlah opened this issue Dec 25, 2020 · 1 comment · Fixed by #2300
Closed

[Question] Why doesn't oneshot::Receiver implement FusedFuture? #2298

TheButlah opened this issue Dec 25, 2020 · 1 comment · Fixed by #2300
Labels
A-channel Area: futures::channel

Comments

@TheButlah
Copy link

If a receiver can only receive once, then shouldn't it implement FusedFuture? I just tried selecting on a receiver using the select! macro, and it wouldn't let me do it since it doesn't implement that trait.
@taiki-e
Copy link
Member

taiki-e commented Dec 26, 2020

I think this is an oversight.

@taiki-e taiki-e added the A-channel Area: futures::channel label Dec 26, 2020
@taiki-e taiki-e mentioned this issue Dec 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-channel Area: futures::channel
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

impl FusedFuture for oneshot::Receiver taiki-e/futures-rs
2 participants
@TheButlah @taiki-e